On Fri, Apr 14, 2017 at 6:32 AM, Pierre Ducroquet <p.p...@pinaraf.info> wrote: > Yesterday while doing a few pg_basebackup, I realized that the integer > parameters were not properly checked against invalid input. > It is not a critical issue, but this could be misleading for an user who > writes -z max or -s 0.5… > I've attached the patch to this mail. Should I add it to the next commit fest > or is it not needed for such small patches ?
A call to atoi is actually equivalent to strtol with the rounding: (int)strtol(str, (char **)NULL, 10); So I don't think this is worth caring. By doing a git grep "atoi(optarg)" you'll see far more places that handle integer options this way as well... -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
