On 02/05/17 20:43, Robert Haas wrote: > On Thu, Apr 20, 2017 at 2:58 PM, Peter Eisentraut > <peter.eisentr...@2ndquadrant.com> wrote: >> On 4/16/17 16:11, Petr Jelinek wrote: >>> Yeah it is, it needs to be fenced to happen only after commit, which is >>> not guaranteed at the point of code, we probably need to put the >>> pgstat_report_stat() inside the if above after the >>> CommitTransactionCommand() (that will make it report stats for changes >>> apply did to pg_subscription_rel after next transaction though) >> >> I think to avoid the latter, we should add more pgstat_report_stat() >> calls, such as in process_syncing_tables_for_apply(). Basically every >> code path that calls CommitTransactionCommand() should have one, no? > > Is there anything left to be committed here? >
Afaics the fix was not committed. Peter wanted more comprehensive fix which didn't happen. I think something like attached should do the job. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
fix-statistics-reporting-in-logical-replication-work.patch
Description: binary/octet-stream
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
