On Fri, May 5, 2017 at 11:57 AM, Andres Freund <and...@anarazel.de> wrote: > Hi, > > On 2017-05-05 11:50:12 +0530, Amit Kapila wrote: >> I see that EndPos can be updated in one of the cases after releasing >> the lock (refer below code). Won't that matter? > > I can't see how it'd in the cases that'd matter for > GetLastImportantRecPtr() - but it'd probably good to note it in the > comment. >
I think it should matter for any record which is not tagged as XLOG_MARK_UNIMPORTANT, but maybe I am missing something in which case comment should be fine. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
