On 05/05/17 19:51, Petr Jelinek wrote: > On 05/05/17 14:40, tushar wrote: >> Hi, >> >> While testing 'logical replication' against v10 , i encountered one >> issue where data stop migrating after ALTER PUBLICATION. >> >> X Server >> \\ Make sure wal_level is set to logical in postgresql.conf file >> \\create table/Insert 1 row -> create table test(n int); insert into t >> values (1); >> \\create publication for all -> create publication pub for ALL TABLES ; >> >> >> Y server >> >> \\ Make sure wal_level is set to logical in postgresql.conf file >> \\create table -> create table test(n int); >> >> \\create Subscription >> >> CREATE SUBSCRIPTION sub CONNECTION 'host=localhost dbname=postgres >> port=5432 ' PUBLICATION pub; >> >> [...] >> >> I think probably syntax of alter subscription is not correct but >> surprisingly it is not throwing an error. >> > > Syntax of ALTER command is correct, syntax of the connection string is > not, you are probably getting errors in log from the replication worker. > > We could check validity of the connection string though to complain > immediately like we do in CREATE. >
The attached does exactly that. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Check-connection-info-in-ALTER-SUBSCRIPTION.patch
Description: binary/octet-stream
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers