On Thu, May 4, 2017 at 07:01:17PM -0300, Alvaro Herrera wrote:
> Thanks for doing this, looks great. A few notes:
>
> <listitem>
> <!--
> Author: Alvaro Herrera <alvhe...@alvh.no-ip.org>
> 2017-03-24 [7b504eb28] Implement multivariate n-distinct coefficients
> Author: Simon Riggs <si...@2ndquadrant.com>
> 2017-04-05 [2686ee1b7] Collect and use multi-column dependency stats
> -->
> <para>
> Add the ability to compute a correlation ratio and the number of
> distinct values on several columns (Tomas Vondra, David Rowley)
> </para>
>
> I think this should be worded in terms of "extended data statistics" or
> such. I think your proposed wording is a bit obscure. How about
> something like "Add extended statistics to improve query planning".
> Also, I'd add myself as co-author, with Tomas' permission.
Already done.
> <listitem>
> <!--
> Author: Alvaro Herrera <alvhe...@alvh.no-ip.org>
> 2017-04-01 [7526e1022] BRIN auto-summarization
> -->
> <para>
> Cause <acronym>BRIN</> index summarization to happen more
> aggressively (Álvaro Herrera)
> </para>
>
> <para>
> Specifically, summarize the previous page range when a new page
> range is created.
> </para>
> </listitem>
>
> I think it should be pointed out that this is optional and defaults to
> off. Maybe start with "add option to ..." (I wonder if it's worth
> creating a linkable area in the docs that explain this feature, so that
> we could have a link in the relnotes entry).
Wow, looking at the patch, there is a lot more going on. I have updated
the docs but please let me know if there is more needed.
Also, can ALTER INDEX change the index summariziation? Should it?
Also, when you remove summarization, when is it re-added? Why would you
remove summarization rather than just re-add it. I must be missing
something.
> <listitem>
> <!--
> Author: Alvaro Herrera <alvhe...@alvh.no-ip.org>
> 2017-04-01 [c655899ba] BRIN de-summarization
> -->
> <para>
> Add function <function>brin_desummarize_range()</> to remove
> <acronym>BRIN</> summarization of a specified range (Álvaro
> Herrera)
> </para>
>
> <para>
> This allows future <acronym>BRIN</> index summarization to be
> more compact. CLARIFY
> </para>
> </listitem>
>
> The point of this change is that if data has changed (delete, update) in
> a way that could use tighter min/max limits, it would be worthwhile to
> remove the previous BRIN tuple so that a new one is created so that
> future scans can skip scanning the range. Maybe word it something like
> "This is useful if UPDATE and DELETE have changed the data to tighter
> limits; a future BRIN index entry will be more accurate"?
OK, updated, but please let me know if more changes are needed.
> <listitem>
> <!--
> Author: Alvaro Herrera <alvhe...@alvh.no-ip.org>
> 2017-03-08 [fcec6caaf] Support XMLTABLE query expression
> -->
> <para>
> Add support for converting <type>XML</>-formatted data into a row
> set (Pavel Stehule, Álvaro Herrera)
> </para>
> XMLTABLE is a sql-standard-specified construct, so we should mention it
> by name in the leading paragraph more prominently ("add support for the
> XMLTABLE standard feature" or something like that); also, I think it
Done.
> should be in the Queries section, not Functions.
Done.
> <para>
> Add <acronym>GUC</> <xref linkend="guc-max-parallel-workers">
> to limit the number of worker processes that can be used for
> parallelism (Julien Rouhaud)
> </para>
>
> <para>
> This can be set lower than <xref
> linkend="guc-max-worker-processes"> to reserve worker processes
> for non-parallel purposes.
> </para>
>
> Strange last phrase. I suggest "...to reserve worker processes for
> purposes other than parallel queries". Also in the leading para, "for
> parallelism" should probably be "for query parallelism".
Done.
> I think commit e306df7f9 ("Full Text Search support for <type>JSON</>
> and <type>JSONB</>") does definitely not belong to section Indexes; I
> think Data Types is a better fit.
Moved.
> I think commits 67dc4ccbb and 1753b1b02 (pg_sequence and pg_sequences)
> should be listed in the opposite order. Maybe merge them into one?
Merged.
> <para>
> This proves better security than the existing <literal>md5</>
> negotiation and storage method.
> </para>
> You probably mean "provides" not "proves".
Fixed.
> <para>
> Allow <acronym>SSL</> configuration to be updated at
> <literal>SIGHUP</> (Andreas Karlsson, Tom Lane)
> </para>
> SIGHUP seems much too technical. How about "... to be updated during
> configurating reload"
Yes, updated.
> I think the entry for commits a734fd5d1 and dafa0848d does not belong in
> the reliability section. In fact I wonder if it's necessary to list
> this one at all.
Yes, I removed it. We can always re-add it later.
> <para>
> Increase the maximum configurable <acronym>WAL</> size to 1
> gigabyte (Beena Emerson)
> </para>
> "WAL segment size" perhaps, and note that this is useful to reduce
> frequency of archive_command?
Yes, updated.
> <para>
> Also add <option>-nosync</> option to disable fsync.
> </para>
> Misspelled --no-sync.
Fixed.
> <para>
> Add log options for <application>pg_ctl</> wait (<option>--wait</>)
> and no-wait (<option>--no-wait</>) (Vik Fearing)
> </para>
> Mispelled "long options".
Fixed.
Applied patch attached.
--
Bruce Momjian <br...@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
diff --git a/doc/src/sgml/release-10.sgml b/doc/src/sgml/release-10.sgml
new file mode 100644
index dafddfb..f4da5b8
*** a/doc/src/sgml/release-10.sgml
--- b/doc/src/sgml/release-10.sgml
***************
*** 458,470 ****
<para>
Add <acronym>GUC</> <xref linkend="guc-max-parallel-workers">
to limit the number of worker processes that can be used for
! parallelism (Julien Rouhaud)
</para>
<para>
This can be set lower than <xref
linkend="guc-max-worker-processes"> to reserve worker processes
! for non-parallel purposes.
</para>
</listitem>
--- 458,470 ----
<para>
Add <acronym>GUC</> <xref linkend="guc-max-parallel-workers">
to limit the number of worker processes that can be used for
! query parallelism (Julien Rouhaud)
</para>
<para>
This can be set lower than <xref
linkend="guc-max-worker-processes"> to reserve worker processes
! for purposes other than parallel queries.
</para>
</listitem>
***************
*** 479,500 ****
<listitem>
<!--
- Author: Andrew Dunstan <and...@dunslane.net>
- 2017-03-31 [e306df7f9] Full Text Search support for <type>JSON</> and
<type>JSONB</>
- -->
- <para>
- Add full text search support for <type>JSON</> and <type>JSONB</>
- (Dmitry Dolgov)
- </para>
-
- <para>
- This is accessed via <function>ts_headline()</> and
- <function>to_tsvector</>. RIGHT SECTION?
- </para>
- </listitem>
-
- <listitem>
- <!--
Author: Tom Lane <t...@sss.pgh.pa.us>
2016-08-23 [77e290682] Create an SP-GiST opclass for inet/cidr.
-->
--- 479,484 ----
***************
*** 525,536 ****
2017-04-01 [7526e1022] BRIN auto-summarization
-->
<para>
! Cause <acronym>BRIN</> index summarization to happen more
! aggressively (Álvaro Herrera)
</para>
<para>
! Specifically, summarize the previous page range when a new page
range is created.
</para>
</listitem>
--- 509,522 ----
2017-04-01 [7526e1022] BRIN auto-summarization
-->
<para>
! Add option to allow <acronym>BRIN</> index summarization to happen
! more aggressively (Álvaro Herrera)
</para>
<para>
! Specifically, a new <link linkend="SQL-ALTERINDEX"><command>CREATE
! INDEX</></> option allows auto-summarizion of the
! previous <acronym>BRIN</> page range when a new page
range is created.
</para>
</listitem>
***************
*** 541,554 ****
2017-04-01 [c655899ba] BRIN de-summarization
-->
<para>
! Add function <function>brin_desummarize_range()</> to remove
! <acronym>BRIN</> summarization of a specified range (Álvaro
Herrera)
</para>
<para>
! This allows future <acronym>BRIN</> index summarization to be
! more compact. CLARIFY
</para>
</listitem>
--- 527,544 ----
2017-04-01 [c655899ba] BRIN de-summarization
-->
<para>
! Add functions to remove and re-add <acronym>BRIN</>
! summarization for <acronym>BRIN</> index ranges (Álvaro
Herrera)
</para>
<para>
! New <acronym>SQL</> function <link
!
linkend="functions-admin-index-table"><function>brin_summarize_range()</></>
! updates <acronym>BRIN</> index summarization for a specified
! range and <function>brin_desummarize_range()</> removes it.
! This is helpful to update summarization of a range that is now
! smaller due to <command>UPDATE</>s and <command>DELETE</>s.
</para>
</listitem>
***************
*** 863,881 ****
<listitem>
<!--
Author: Peter Eisentraut <pete...@gmx.net>
- 2016-11-18 [67dc4ccbb] Add pg_sequences view
- -->
- <para>
- Add <link
- linkend="view-pg-sequences"><structname>pg_sequences</></> view
- to show all sequences (Peter Eisentraut)
- </para>
- </listitem>
-
- <listitem>
- <!--
- Author: Peter Eisentraut <pete...@gmx.net>
2016-12-20 [1753b1b02] Add pg_sequence system catalog
-->
<para>
Create a <link
--- 853,861 ----
<listitem>
<!--
Author: Peter Eisentraut <pete...@gmx.net>
2016-12-20 [1753b1b02] Add pg_sequence system catalog
+ Author: Peter Eisentraut <pete...@gmx.net>
+ 2016-11-18 [67dc4ccbb] Add pg_sequences view
-->
<para>
Create a <link
***************
*** 884,892 ****
</para>
<para>
! Sequence metadata includes start, increment, etc, which is now
! transactional. Sequence counters are still stored in separate
! heap relations.
</para>
</listitem>
--- 864,874 ----
</para>
<para>
! Sequence metadata includes start, increment, etc,
! which is now transactional. Sequence counters are
! still stored in separate heap relations. Also add <link
! linkend="view-pg-sequences"><structname>pg_sequences</></> view
! to show all sequences.
</para>
</listitem>
***************
*** 1167,1173 ****
</para>
<para>
! This proves better security than the existing <literal>md5</>
negotiation and storage method.
</para>
</listitem>
--- 1149,1155 ----
</para>
<para>
! This provides better security than the existing <literal>md5</>
negotiation and storage method.
</para>
</listitem>
***************
*** 1238,1245 ****
2017-01-04 [6667d9a6d] Re-allow SSL passphrase prompt at server start,
but not
-->
<para>
! Allow <acronym>SSL</> configuration to be updated at
! <literal>SIGHUP</> (Andreas Karlsson, Tom Lane)
</para>
<para>
--- 1220,1227 ----
2017-01-04 [6667d9a6d] Re-allow SSL passphrase prompt at server start,
but not
-->
<para>
! Allow <acronym>SSL</> configuration to be updated during
! configuration reload (Andreas Karlsson, Tom Lane)
</para>
<para>
***************
*** 1317,1339 ****
</para>
</listitem>
- <listitem>
- <!--
- Author: Robert Haas <rh...@postgresql.org>
- 2016-11-21 [a734fd5d1] autovacuum: Drop orphan temp tables more
quickly but wit
- Author: Tom Lane <t...@sss.pgh.pa.us>
- 2016-11-27 [dafa0848d] Code review for early drop of orphaned temp
relations in
- -->
- <para>
- Remove orphaned temporary tables more aggressively (Robert Haas,
- Tom Lane)
- </para>
-
- <para>
- Previously such tables were removed only when necessary. SECTION?
- </para>
- </listitem>
-
</itemizedlist>
<sect5>
--- 1299,1304 ----
***************
*** 1376,1383 ****
2017-04-05 [00b6b6feb] Allow \-\-with-wal-segsize=n up to n=1024MB
-->
<para>
! Increase the maximum configurable <acronym>WAL</> size to 1
! gigabyte (Beena Emerson)
</para>
</listitem>
--- 1341,1354 ----
2017-04-05 [00b6b6feb] Allow \-\-with-wal-segsize=n up to n=1024MB
-->
<para>
! Increase the maximum configurable <acronym>WAL</> segment size
! to one gigabyte (Beena Emerson)
! </para>
!
! <para>
! Larger <acronym>WAL</> segment sizes allows for fewer
! <xref linkend="guc-archive-command"> invocations and fewer
! <acronym>WAL</> files to manage.
</para>
</listitem>
***************
*** 1571,1576 ****
--- 1542,1560 ----
<listitem>
<!--
+ Author: Alvaro Herrera <alvhe...@alvh.no-ip.org>
+ 2017-03-08 [fcec6caaf] Support XMLTABLE query expression
+ -->
+ <para>
+ Add <link
+ linkend="functions-xml-processing-xmltable"><function>XMLTABLE</></>
+ function that converts <type>XML</>-formatted data into a row set
+ (Pavel Stehule, Álvaro Herrera)
+ </para>
+ </listitem>
+
+ <listitem>
+ <!--
Author: Tom Lane <t...@sss.pgh.pa.us>
2016-11-22 [906bfcad7] Improve handling of "UPDATE ... SET
(column_list) = row_
-->
***************
*** 1821,1826 ****
--- 1805,1826 ----
<itemizedlist>
+ <listitem>
+ <!--
+ Author: Andrew Dunstan <and...@dunslane.net>
+ 2017-03-31 [e306df7f9] Full Text Search support for <type>JSON</> and
<type>JSONB</>
+ -->
+ <para>
+ Add full text search support for <type>JSON</> and <type>JSONB</>
+ (Dmitry Dolgov)
+ </para>
+
+ <para>
+ This is accessed via <function>ts_headline()</> and
+ <function>to_tsvector</>.
+ </para>
+ </listitem>
+
<listitem>
<!--
Author: Stephen Frost <sfr...@snowman.net>
***************
*** 1939,1961 ****
<listitem>
<!--
- Author: Alvaro Herrera <alvhe...@alvh.no-ip.org>
- 2017-03-08 [fcec6caaf] Support XMLTABLE query expression
- -->
- <para>
- Add support for converting <type>XML</>-formatted data into a row
- set (Pavel Stehule, Álvaro Herrera)
- </para>
-
- <para>
- This is done by referencing the new <link
- linkend="functions-xml-processing-xmltable"><function>XMLTABLE</></>
- function.
- </para>
- </listitem>
-
- <listitem>
- <!--
Author: Magnus Hagander <mag...@hagander.net>
2017-01-18 [d00ca333c] Implement array version of jsonb_delete and
operator
-->
--- 1939,1944 ----
***************
*** 2572,2578 ****
</para>
<para>
! Also add <option>-nosync</> option to disable fsync.
</para>
</listitem>
--- 2555,2561 ----
</para>
<para>
! Also add <option>--nosync</> option to disable fsync.
</para>
</listitem>
***************
*** 2617,2623 ****
2016-10-19 [0be22457d] pg_ctl: Add long options for -w and -W
-->
<para>
! Add log options for <application>pg_ctl</> wait (<option>--wait</>)
and no-wait (<option>--no-wait</>) (Vik Fearing)
</para>
</listitem>
--- 2600,2606 ----
2016-10-19 [0be22457d] pg_ctl: Add long options for -w and -W
-->
<para>
! Add long options for <application>pg_ctl</> wait (<option>--wait</>)
and no-wait (<option>--no-wait</>) (Vik Fearing)
</para>
</listitem>
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
