On 08/05/17 22:55, Peter Eisentraut wrote: > On 5/5/17 13:01, Petr Jelinek wrote: >> What do you think of attached. I actually did add RESTRICT/CASCADE, in a >> way that if there is slot RESTRICT will refuse to drop subscription and >> CASCADE will try to drop it. Still all errors. >> >> The new way to not drop slot is to set slot_name to NONE which is new >> value that I invented (inspiration from OWNED BY sequences) which >> basically disassociates the subscription from slot. >> >> It's slightly less automatic this way but perhaps that's not a bad >> thing, at least nobody will drop slots by mistake while we still make >> sure that slots are not left over without anybody noticing. > > I think this is OK. Could you send a version of this patch based on > master please? >
Here it is. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Remove-the-NODROP-SLOT-option-from-DROP-SUBSCRIPTION-0508.patch
Description: binary/octet-stream
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
