On 2017/05/09 22:52, Mark Dilger wrote: > >> On May 9, 2017, at 12:18 AM, Amit Langote <langote_amit...@lab.ntt.co.jp> >> wrote: >> >> Hi, >> >> On 2017/05/05 9:38, Mark Dilger wrote: >>> Hackers, >>> >>> just FYI, I cannot find any regression test coverage of this part of the >>> grammar, not >>> even in the contrib/ directory or TAP tests. I was going to submit a patch >>> to help out, >>> and discovered it is not so easy to do, and perhaps that is why the >>> coverage is missing. >> >> I think we could add the coverage by defining a dummy C FDW handler >> function in regress.c. I see that some other regression tests use C >> functions defined there, such as test_atomic_ops(). >> >> What do you think about the attached patch? I am assuming you only meant >> to add tests for the code in foreigncmds.c (CREATE/ALTER FOREIGN DATA >> WRAPPER). > > Thank you for creating the patch. I only see one small oversight, which is > the > successful case of ALTER FOREIGN DATA WRAPPER ... HANDLER ... is still > not tested. I added one line for that in the attached modification of your > patch.
Ah right, thanks. Adding this to the next commitfest as Ashutosh suggested. Regards, Amit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers