Hi > On 4 April 2017 at 19:13, Masahiko Sawada <sawada.m...@gmail.com> wrote: > > Other than that issue current patch still could not pass 'make check' > test of contrib/test_decoding.
Just a note about this patch. Of course time flies by and it needs rebase, but also there are few failing tests right now: * one that was already mentioned by Masahiko * one from `ddl`, where expected is: ``` SELECT slot_name, plugin, slot_type, active, NOT catalog_xmin IS NULL AS catalog_xmin_set, xmin IS NULl AS data_xmin_not_set, pg_wal_lsn_diff(restart_lsn, '0/01000000') > 0 AS some_wal FROM pg_replication_slots; slot_name | plugin | slot_type | active | catalog_xmin_set | data_xmin_not_set | some_wal -----------------+---------------+-----------+--------+------------------+-------------------+---------- regression_slot | test_decoding | logical | f | t | t | t (1 row) ``` but the result is: ``` SELECT slot_name, plugin, slot_type, active, NOT catalog_xmin IS NULL AS catalog_xmin_set, xmin IS NULl AS data_xmin_not_set, pg_wal_lsn_diff(restart_lsn, '0/01000000') > 0 AS some_wal FROM pg_replication_slots; ERROR: function pg_wal_lsn_diff(pg_lsn, unknown) does not exist LINE 5: pg_wal_lsn_diff(restart_lsn, '0/01000000') > 0 AS some_w... ^ HINT: No function matches the given name and argument types. You might need to add explicit type casts. ```