On 2017-05-14 14:54:37 +0200, Petr Jelinek wrote: > On 13/05/17 22:23, Andres Freund wrote: > >> And wait for session 3 to finish slot creation, takes about 20 mins on > >> my laptop without patches, minute and half with your patches for 0004 > >> and 0005 (or with your 0004 and my 0005) and about 2s with my original > >> 0004 and 0005. > > > > Is that with assertions enabled or not? With assertions all the time > > post patches seems to be spent in some Asserts in reorderbuffer.c, > > without it takes less than a second for me here. > > > > Right you are, I always forget to switch that off before benchmarks.
Phew ;) > > I'm appylying these now. > > Cool. Just for posterity, this also fixes the issue number 3 as the > switch to consistent state is done purely based on xl_running_xacts and > not decoded commits/aborts. Cool. Although I'm still not convinced, as noted somewhere in this thread, that it actually did much to start with ;) Greetings, Andres Freund -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers