On Sat, May 20, 2017 at 5:32 AM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> We'd probably be better off to implement case-insensitivity the hard way.
> There is a reason why none of our other flex scanners use this switch.
Do you think that it would be better to list the letter list for each
keyword in repl_scanner.l or have something more generic? As not that
many commands are added in the replication protocol, I would think
that this is more than enough for each command, say:
[Ss][Ll][Oo][Tt] { return K_SLOT; }
etc.
> While I'm whining ... it looks like the other flex options selected here
> were cargo-culted in rather than being thought about. Surely we don't
> run syncrep_scanner often enough, nor over so much data, that it's a
> good tradeoff to use the options for larger tables.
Indeed, good catch.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
