It seems that 14cca1b (use static inline functions for float <-> Datum conversions) has an implicit narrowing conversion in one of those functions.
If building an extension with gcc's -Wconversion warning enabled (*cough* pljava *cough* ... the Maven plugin that runs the compiler enables the warning by default), this makes for a noisy build. The warning is harmless, but repeated everywhere postgres.h is included. An explicit cast is enough to suppress it. -Chap
--- src/include/postgres.h 2017-05-15 17:20:59.000000000 -0400 +++ src/include/postgres.h 2017-05-31 00:21:27.329393499 -0400 @@ -679,7 +679,7 @@ float4 retval; } myunion; - myunion.value = GET_4_BYTES(X); + myunion.value = (int32)GET_4_BYTES(X); return myunion.retval; } #else
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
