unaccent.patch
Description: Binary data
On Sun, May 28, 2017 at 7:55 PM, Dang Minh Huong < kakalo...@gmail.com> wrote: Thanks for reporting and lecture about unicode. I attached a patch as the instruction from Thomas. Could you confirm it.
- is_plain_letter(table[codepoint.combining_ids[0]]) and \ + (is_plain_letter(table[codepoint.combining_ids[0]]) or\ + len(table[codepoint.combining_ids[0]].combining_ids) > 1) and \ Shouldn't you use "or is_letter_with_marks()", instead of "or len(...) 1"? Your test might catch something that isn't based on a 'letter'
(according to is_plain_letter). Otherwise this looks pretty good to me. Please add it to the next commitfest.
Thanks for confirm, sir. I will add it to the next CF soon.
Sorry for lately response. I attach the update patch.
--- Thanks and best regards, Dang Minh Huong
|