On Tue, Jun 6, 2017 at 5:01 PM, Peter Geoghegan <p...@bowt.ie> wrote: > Also, ISTM that the code within ENRMetadataGetTupDesc() probably > requires more explanation, resource management wise.
Also, it's not clear why it should be okay that the new type of ephemeral RTEs introduced don't have permissions checks. There are currently cases where the user cannot see data that they inserted themselves (e.g., through RETURNING), on the theory that a before row trigger might have modified the final contents of the tuple in a way that the original inserter isn't supposed to know details about. As the INSERT docs say, "Use of the RETURNING clause requires SELECT privilege on all columns mentioned in RETURNING". Similarly, the excluded.* pseudo-relation requires select privilege (on the corresponding target relation columns) in order to be usable by ON CONFLICT DO UPDATE. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers