On Wed, Jun 7, 2017 at 1:23 AM, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > On 2017/06/07 11:57, Amit Langote wrote: >> How about we export ExecPartitionCheck() out of execMain.c and call it >> just before ExecFindPartition() using the root table's ResultRelInfo? > > Turns out there wasn't a need to export ExecPartitionCheck after all. > Instead of calling it from execModifyTable.c and copy.c, it's better to > call it at the beginning of ExecFindPartition() itself. That way, there > is no need to add the same code both in CopyFrom() and ExecInsert(), nor > is there need to make ExecPartitionCheck() public. That's how the patch > attached with the previous email does it anyway.
Cool. I think this is a sensible approach, and have committed the patch. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
