Hi, In this patch in walsender.c sendTimeLineIsHistoric is set to true when current and ThisTimeLineID are equal.
sendTimeLineIsHistoric = state->currTLI == ThisTimeLineID; Shouldn't sendTimeLineIsHistoric is true when state->currTLI is less than ThisTimeLineID. When i applied the timeline following patch alone pg_recvlogical quits in startup phase but when i made the above change pg_recvlogical works although timeline following doesn't work. Thanks, Sanyam Jain ________________________________ From: pgsql-hackers-ow...@postgresql.org <pgsql-hackers-ow...@postgresql.org> on behalf of Robert Haas <robertmh...@gmail.com> Sent: Wednesday, April 5, 2017 3:25:50 PM To: Andres Freund Cc: Craig Ringer; Simon Riggs; Thom Brown; Michael Paquier; Petr Jelinek; PostgreSQL Hackers Subject: Re: [HACKERS] Logical decoding on standby On Wed, Apr 5, 2017 at 10:32 AM, Andres Freund <and...@anarazel.de> wrote: > On 2017-04-05 17:18:24 +0800, Craig Ringer wrote: >> On 5 April 2017 at 04:19, Andres Freund <and...@anarazel.de> wrote: >> > On 2017-04-04 22:32:40 +0800, Craig Ringer wrote: >> >> I'm much happier with this. I'm still fixing some issues in the tests >> >> for 03 and tidying them up, but 03 should allow 01 and 02 to be >> >> reviewed in their proper context now. >> > >> > To me this very clearly is too late for v10, and now should be moved to >> > the next CF. >> >> I tend to agree that it's late in the piece. It's still worth cleaning >> it up into a state ready for early pg11 though. > > Totally agreed. Based on this exchange, marked as "Moved to next CF". -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
