On 23 June 2017 at 08:23, Simon Riggs <si...@2ndquadrant.com> wrote: > On 23 June 2017 at 08:21, Andres Freund <and...@anarazel.de> wrote: >> On 2017-06-07 10:17:31 -0700, Andres Freund wrote: >>> On 2017-05-08 09:12:13 -0400, Tom Lane wrote: >>> > Simon Riggs <si...@2ndquadrant.com> writes: >>> > > So rearranged code a little to keep it lean. >>> > >>> > Didn't you break it with that? As it now stands, the memcpy will >>> > copy the nonzero value. >>> >>> I've not seen a fix and/or alleviating comment about this so far. Did I >>> miss something? >> >> Simon, FWIW, I plan to either revert or fix this up soon-ish. Unless >> you're going to actually respond on this thread? > > Sorry, I've only just seen Tom's reply. Will fix.
I don't see a bug. Perhaps I'm tired and can't see it yet. Will fix if you thwack me with the explanation. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers