On 2017-06-28 13:31:27 -0400, Tom Lane wrote: > I'm not hearing anyone speaking against doing this now, so I'm going > to go ahead with it.
Cool. > While looking this over again, I got worried about the fact that pg_ctl > is #including "miscadmin.h". That's a pretty low-level backend header > and it wouldn't be surprising at all if somebody tried to put stuff in > it that wouldn't compile frontend-side. I think we should take the > opportunity, as long as we're touching this stuff, to split the #defines > that describe the contents of postmaster.pid into a separate header file. > Maybe "utils/pidfile.h" ? Yes, that sounds like a valid concern, and solution. - Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
