Hi, I found a type in the comment for XLByteToSeg() and XLByteToPrevSeg(). This says "Compute ID and segment from an XLogRecPtr", but these macros compute only segment numbers. I think "Compute a segment number from an XLogRecPtr" is correct.
The definition of these macros were modified by the following commit, but the comment were not. commit dfda6ebaec6763090fb78b458a979b558c50b39b Author: Heikki Linnakangas <heikki.linnakan...@iki.fi> Date: Sun Jun 24 18:06:38 2012 +0300 Regards, -- Yugo Nagata <nag...@sraoss.co.jp>
diff --git a/src/include/access/xlog_internal.h b/src/include/access/xlog_internal.h index a661ec0..7453dcb 100644 --- a/src/include/access/xlog_internal.h +++ b/src/include/access/xlog_internal.h @@ -96,7 +96,7 @@ typedef XLogLongPageHeaderData *XLogLongPageHeader; (dest) = (segno) * XLOG_SEG_SIZE + (offset) /* - * Compute ID and segment from an XLogRecPtr. + * Compute a segment number from an XLogRecPtr. * * For XLByteToSeg, do the computation at face value. For XLByteToPrevSeg, * a boundary byte is taken to be in the previous segment. This is suitable
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
