Attached patch looks good except the excessive tab stops: + # (change requires restart)
I will commit/push this with removing the excessive tab stops if there's no objection. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp > On Thu, 27 Jul 2017 14:38:29 +0900 > Masahiko Sawada <sawada.m...@gmail.com> wrote: > >> On Thu, Jul 27, 2017 at 10:14 AM, Yugo Nagata <nag...@sraoss.co.jp> wrote: >> > Hi, >> > >> > I found that postgresql.conf.sample is missing a comment >> > to note that changing max_logical_replication_workers requires >> > restart of the server. >> > >> > Other such parameters has the comments, so I think the new >> > parameter also needs this. Attached is a simple patch to fix >> > this. >> > >> >> Good point. Similarly, dynamic_shared_memory_type and event_source are >> required restarting to change but are not mentioned in >> postgresql.conf.sample. Should we add a comment as well? > > I think so. The updated patch is attached. > >> >> Regards, >> >> -- >> Masahiko Sawada >> NIPPON TELEGRAPH AND TELEPHONE CORPORATION >> NTT Open Source Software Center > > > -- > Yugo Nagata <nag...@sraoss.co.jp> -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
