On Fri, Aug 4, 2017 at 9:44 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > There is no need to use Parentheses around opaque. I mean there is no > problem with that, but it is redundant and makes code less readable.
Amit, I'm sure you know this, but just for the benefit of anyone who doesn't: We often include these kinds of extra parentheses in macros, for good reason. Suppose you have: #define mul(x,y) x * y If the user says mul(2+3,5), it will expand to 2 + 3 * 5 = 17, which is wrong. If you instead do this: #define mul(x,y) (x) * (y) ...then mul(2+3,5) expands to (2 + 3) * (5) = 25, which is what the user of the macro is expecting to get. Outside of macro definitions, as you say, there's no point and we should avoid it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
