Amit Kapila <amit.kapil...@gmail.com> writes:
> On Mon, Aug 28, 2017 at 6:34 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
>> If what you're complaining about is that I put back the "if
>> (outerPlan->chgParam == NULL)" test to allow postponement of the
>> recursive ExecReScan call, I'm afraid that it's mere wishful
>> thinking that omitting that test in nodeGather did anything.
> Previously outerPlan->chgParam will be NULL, so I think rescan's won't
> be postponed.
That seems like an unacceptably fragile assumption. Even if it happens to
be true today, we would need to fix it sooner or later. (And I kinda
suspect it's possible to break it today, anyway. Treating PARAM_EXEC
Params as parallel-restricted seems to lock out the easiest cases, but we
have param slots that don't correspond to any Param node, eg for recursive
union worktables. replace_nestloop_params is also a source of PARAM_EXEC
Params that won't be detected during is_parallel_safe() tests, because it
happens later.)
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
