On 29 August 2017 at 22:02, Andres Freund <and...@anarazel.de> wrote:
> Hi, > > On 2017-08-29 13:42:05 +0200, Simone Gotti wrote: > > On Tue, Aug 29, 2017 at 12:13 PM, Alvaro Herrera > > <alvhe...@2ndquadrant.com> wrote: > > > > > > > Hi Alvaro, > > > > > Simone Gotti wrote: > > > > Hi all, > > > > > > > > I noticed that in postgres 10beta3, calling pg_drop_replication_slot > on an > > > > active slot will block until it's released instead of returning an > error > > > > like > > > > done in pg 9.6. Since this is a change in the previous behavior and > the docs > > > > wasn't changed I made a patch to restore the previous behavior. > > > > > > Changing that behavior was the entire point of the cited commit. > > > > Sorry, I was thinking that the new behavior was needed for internal > > future functions since the doc wasn't changed. > > FWIW, I also don't think it's ok to just change the behaviour > unconditionally and without a replacement for existing behaviour. Seems like it just needs a new argument nowait DEFAULT false Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
