Hi, Adrien! On Mon, Sep 4, 2017 at 3:57 PM, Adrien Nayrat <adrien.nay...@dalibo.com> wrote:
> On 08/30/2017 02:26 PM, Alexander Korotkov wrote: > I reviewed this patch. It works as expected but I have few remarks : > Thank you for reviewing my patch!. > * There is a warning during compilation : > > gram.y: In function ‘base_yyparse’: > gram.y:2090:6: warning: ISO C90 forbids mixed declarations and code > [-Wdeclaration-after-statement] > AlterTableCmd *n = makeNode(AlterTableCmd); > ^~~~~~~~~~~~~ > Fixed. > If I understand we should declare AlterTableCmd *n [...] before "if"? > > * I propose to add "Stats target" information in psql verbose output > command > \d+ (patch attached with test) > > \d+ tmp_idx > Index "public.tmp_idx" > Column | Type | Definition | Storage | Stats target > --------+------------------+------------+---------+-------------- > a | integer | a | plain | > expr | double precision | (d + e) | plain | 1000 > b | cstring | b | plain | > btree, for table "public.tmp" > > > * psql completion is missing (added to previous patch) > Looks good for me. I've integrated those changes in the patch. New revision is attached. ------ Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
alter-index-statistics-3.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
