On Wed, Sep 13, 2017 at 1:55 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 9/11/17 23:58, Thomas Munro wrote: >> Sounds good. Here it is with $username. It's nice not to have to >> escape any characters in URLs. I suppose more keywords could be added >> in follow-up patches if someone thinks that would be useful >> ($hostname, $dbname, ...?). I got sick of that buffer sizing code and >> changed it to use StringInfo. Here also are your test patches tweaked >> slightly: 0002 just adds FreeBSD support as per previous fixup and >> 0003 changes to $username. > > Committed the feature patch.
Thanks! > Any further thoughts on the test suite? Otherwise I'll commit it as we > have it, for manual use. I wonder if there is a reasonable way to indicate or determine whether you have slapd installed so that check-world could run this test... -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers