On Wed, Sep 13, 2017 at 1:04 PM, Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote: > The CF status of this patch turned into "Waiting on Author" by > automated CI checking. However, I still don't get any error even > on the current master (69835bc) after make distclean. Also I > don't see any difference between the "problematic" patch and my > working branch has nothing different other than patching line > shifts. (So I haven't post a new one.) > > I looked on the location heapam.c:2502 where the CI complains at > in my working branch and I found a different code with the > complaint. > > https://travis-ci.org/postgresql-cfbot/postgresql/builds/274777750 > > 1363 heapam.c:2502:18: error: ‘HEAP_INSERT_SKIP_WAL’ undeclared (first use in > this function) > 1364 if (!(options & HEAP_INSERT_SKIP_WAL) && RelationNeedsWAL(relation)) > > heapam.c:2502@work branch > 2502: /* XLOG stuff */ > 2503: if (BufferNeedsWAL(relation, buffer)) > > So I conclude that the CI mechinery failed to applly the patch > correctly.
Hi Horiguchi-san, Hmm. Here is that line in heamap.c in unpatched master: https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/access/heap/heapam.c;h=d20f0381f3bc23f99c505ef8609d63240ac5d44b;hb=HEAD#l2485 It says: 2485 if (!(options & HEAP_INSERT_SKIP_WAL) && RelationNeedsWAL(relation)) After applying fix-wal-level-minimal-michael-horiguchi-3.patch from this message: https://www.postgresql.org/message-id/20170912.131441.20602611.horiguchi.kyotaro%40lab.ntt.co.jp ... that line is unchanged, although it has moved to line number 2502. It doesn't compile for me, because your patch removed the definition of HEAP_INSERT_SKIP_WAL but hasn't removed that reference to it. I'm not sure what happened. Is it possible that your patch was not created by diffing against master? -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers