Hi, On 2017-09-13 14:28:34 -0700, Jeff Janes wrote: > In 10beta4 and 11dev, If I run the below it enters an uninterruptible > state. After the insert starts, I give 15 or seconds or so until the > memory usage starts to grow due to enqueued triggers checks. Then I can't > interrupt it with either ctrl-C in psql or kill -15 <pid> from another > terminal. > > I have to do kill -9 <pid> > > create table foo (x int); > create or replace function notice () returns trigger as $$ begin raise > notice 'asdfsdf'; return NEW; END;$$ language plpgsql; > create trigger foobar after insert on foo for each row execute procedure > notice(); > insert into foo select * from generate_series(1,100000000); > > Git bisect lays the blame here which certainly seems plausible: > > commit d47cfef7116fb36349949f5c757aa2112c249804 > Author: Andres Freund <and...@anarazel.de> > Date: Tue Jul 25 17:37:17 2017 -0700 > > Move interrupt checking from ExecProcNode() to executor nodes.
Indeed that seems plausible. I guess something like the attached should fix the issue? Greetings, Andres Freund
diff --git a/src/backend/executor/execScan.c b/src/backend/executor/execScan.c index 47a34a044a..3fec198589 100644 --- a/src/backend/executor/execScan.c +++ b/src/backend/executor/execScan.c @@ -40,6 +40,8 @@ ExecScanFetch(ScanState *node, { EState *estate = node->ps.state; + CHECK_FOR_INTERRUPTS(); + if (estate->es_epqTuple != NULL) { /* @@ -157,8 +159,6 @@ ExecScan(ScanState *node, { TupleTableSlot *slot; - CHECK_FOR_INTERRUPTS(); - slot = ExecScanFetch(node, accessMtd, recheckMtd); /*
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers