On Tue, Sep 19, 2017 at 8:48 AM, Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote: > Though a bit uneasy to have similar code on both side > (XLogBackgroundFlush and XLogSetAsyncXactLSN) but +1 to this from > me.
This patch wasn't formatted very nicely; attached is a version that pgindent likes better and doesn't bust past 80 columns. I think this patch needs significantly better comments. There's no explanation of the rather complex formula the patch proposed to use. Maybe it's just copied from someplace else that does have a comment, but in that case, the comments here should mention that. And the comment in the other place should probably be updated too, like: /* Make sure to keep this in sync with the similar logic in XLogDoAwesomeStuff() */ -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
change_walwriter_wakeup_v3.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
