On Tue, Sep 5, 2017 at 3:41 PM, Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote: > Thank you for the opinions. > > At Tue, 29 Aug 2017 15:00:57 +0900, Masahiko Sawada <sawada.m...@gmail.com> > wrote in <CAD21AoD76_QkYBwu8=numv0sp3dec9x+dufb6-xbqyuuuuh...@mail.gmail.com> >> On Tue, Aug 29, 2017 at 10:16 AM, Robert Haas <robertmh...@gmail.com> wrote: >> > On Mon, Aug 28, 2017 at 5:26 AM, Kyotaro HORIGUCHI >> > <horiguchi.kyot...@lab.ntt.co.jp> wrote: >> >> Currently the message shows the '%d skipped-frozen' message but >> >> it is insufficient to verify the true effect. This is a patch to >> >> show mode as 'aggressive' or 'normal' in the closing message of >> >> vacuum. %d frozen-skipped when 'aggressive mode' shows the true >> >> effect of ALL_FROZEN. >> >> >> >> I will add this patch to CF2017-09. >> > >> > I would be a bit inclined to somehow show aggressive if it's >> > aggressive and not insert anything at all otherwise. That'd probably >> > require two separate translatable strings in each case, but maybe >> > that's OK. >> > >> > What do other people think? >> >> FWIW I prefer the Robert's idea; not insert anything if normal vacuum. > > Though the form is intending to simplify parsing of the message, > keeping the previous format if nothing special is convincing. > > How about the followings? > > "automatic [agressive ]vacuum of table \"%s..." > "[aggressive ]vacuuming \"%s..." >
I've reviewed the latest patch and it looks good to me. I marked it as Ready for Committer. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
