Ashutosh Bapat wrote: > On Fri, Nov 3, 2017 at 1:42 PM, Alvaro Herrera <alvhe...@alvh.no-ip.org> > wrote:
> > I think adding "is partitioned" at end of line isn't good; looks like a > > phrase but isn't translatable. Maybe add keyword PARTITIONED instead? > > In that case may be we should separate bounds and "PARTITIONED" with a > ",". "part_default DEFAULT, PARTITIONED" would read better than > "part_default DEFAULT PARTITIONED"? Hmm, I vote +0.5 for the comma. > > Having the DEFAULT partition show up in the middle of the list is weird. > > Agreed. But that's true even without this patch. Yes. > > Is it possible to put it at either start or end of the list? > > Right now, we could do that if we order the list by bound expression; > lexically DEFAULT would come before FOR VALUES ... . But that's not > future-safe; we may have a bound expression starting with A, B or C. > Beyond that it really gets tricky to order the partitions by bounds. I was just thinking in changing the query to be "order by is_the_default_partition, partition_name" instead of just "order by partition_name". Sorting by bounds rather than name (a feature whose worth should definitely be discussed separately IMV) sounds a lot more complicated. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
