Hi! On Tue, Nov 7, 2017 at 4:34 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote:
> I understood the necessity of this patch and reviewed two patches. > Good, thank you. > For /fix-bloom-wal-check.patch, it looks good to me. I found no > problem. But for wal-check-on-bloom-check.patch, if you want to run > wal-check even when running 'make check' or 'make check-world', we can > just add wal-check test as follows? > > diff --git a/contrib/bloom/Makefile b/contrib/bloom/Makefile > index 13bd397..c1566d4 100644 > --- a/contrib/bloom/Makefile > +++ b/contrib/bloom/Makefile > @@ -20,5 +20,7 @@ include $(top_builddir)/src/Makefile.global > include $(top_srcdir)/contrib/contrib-global.mk > endif > > +check: wal-check > + > wal-check: temp-install > $(prove_check) > I've tried this version Makefile. And I've seen the only difference: when tap tests are enabled, this version of Makefile runs tap tests before regression tests. While my version of Makefile runs tap tests after regression tests. That seems like more desirable behavior for me. But it would be sill nice to simplify Makefile. ------ Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
