On Tue, Nov 7, 2017 at 4:31 AM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: >> Updated patch attached. > Patch rebased.
I think the earlier concerns about the performance impact of this are probably very valid concerns, and I don't see how the new version of the patch gets us much closer to solving them. I am also not sure I understand how the backend_write_blocks column is intended to work. The only call to pgstat_send_walwrites() is in WalWriterMain, so where do the other backends report anything? Also, if there's only ever one global set of counters (as opposed to one per table, say) then why use the stats collector machinery for this at all, vs. having a structure in shared memory that can be updated directly? It seems like adding a lot of overhead for no functional benefit. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
