On Thu, Nov 9, 2017 at 2:42 AM, Fabrízio de Royes Mello <fabriziome...@gmail.com> wrote: > On Wed, Nov 8, 2017 at 12:47 AM, Michael Paquier <michael.paqu...@gmail.com> > wrote: >> - Let's restrict the logging to a role name instead of a database >> name, and let's parametrize it with a setting in the temporary >> configuration file. Let's not bother about multiple role support with >> a list, for the sake of tests and simplicity only defining one role >> looks fine to me. Comments in the code should be clear about the >> dependency. > > Makes sense and simplify the test code. Fixed.
+ if (!strcmp(username, "regress_sess_hook_usr2")) + { + const char *dbname; [...] +++ b/src/test/modules/test_session_hooks/session_hooks.conf @@ -0,0 +1 @@ +shared_preload_libraries = 'test_session_hooks' Don't you think that this should be a GUC? My previous comment outlined that. I won't fight hard on that point in any case, don't worry. I just want to make things clear :) -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers