On Sat, Oct 28, 2017 at 03:43:02PM -0700, Michael Paquier wrote: > couldn't we envisage to just use > malloc? pgwin32_message_to_UTF16() is called in two places in elog.c, > and there is a full control on the error code paths.
Switching to malloc is feasible, but it wouldn't enable PostgreSQL to handle non-ASCII messages any earlier. Messages should be ASCII-only until the init_locale(LC_CTYPE) call initializes MessageEncoding. (Before that call, pgwin32_message_to_UTF16() assumes the message is UTF8-encoded. I've expanded the comments slightly. We easily comply with that restriction today.) On Fri, Nov 03, 2017 at 11:10:14AM +0000, Michael Paquier wrote: > I am > switching the patch as ready for committer, I definitely agree that > you are taking the write approach here. Committed both patches. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers