Andrew Dunstan wrote: > >Nice. Only two comments --- does this mean we should remove log_pid? > >Seems it is now duplicate functionality. Is that the only duplication? > >Also, I don't see any documention changes in the patch, but I assume you > >will work on that before final. > > > > I will do docs. We could sensibly get rid of log_pid and log_timestamp > with my latest patch. I would also suggest getting rid of > log_source_port, since there really isn't any reason *not* to log the > source port. Do you want me to make those changes in my patch? Or I can > leave them for now and we can get rid of them when everyone is happy.
I agree, but let's make it a separate patch. Oh, I think we still need log_timestamp for postmaster-generated lines, no? What does log_line_info output for postmaster-generated logs? Also, should we call the option just log_line? Is that clearer, or log_line_prefix? -- Bruce Momjian | http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
