This doesn't look good. If we throw a WARNING, why do we not insert anything into pg_description. Seems we should throw an error, or do the insert with a warning.
--------------------------------------------------------------------------- Mike Mascari wrote: > Andrew Dunstan wrote: > > Bruce Momjian wrote: > > > >> Another problem is that pg_description is per-database, while > >> pg_user/group are global for all databases. > >> > >> > >> > > databases are also per cluster, but we have comments on those. > > > > Could we keep the user/group comments in those tables instead of in > > pg_description? > > The comments are stored only in the database's pg_description where > the COMMENT ON took place. This caused dump/reload problems. I > believe Rod Taylor added the new warning: > > [EMAIL PROTECTED] select count(*) from pg_description; > count > ------- > 1541 > (1 row) > > [EMAIL PROTECTED] COMMENT ON DATABASE test IS 'Hello'; > WARNING: database comments may only be applied to the current database > COMMENT > > [EMAIL PROTECTED] select count(*) from pg_description; > count > ------- > 1541 > (1 row) > > [EMAIL PROTECTED] COMMENT ON DATABASE estore IS 'A good comment'; > COMMENT > > [EMAIL PROTECTED] select count(*) from pg_description; > count > ------- > 1542 > (1 row) > > [EMAIL PROTECTED] select count(*) from pg_description; > count > ------- > 1541 > (1 row) > > > Mike Mascari > > > ---------------------------(end of broadcast)--------------------------- > TIP 6: Have you searched our list archives? > > http://archives.postgresql.org > -- Bruce Momjian | http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html
