Marko Kreen wrote:
On Thu, Jan 06, 2005 at 11:39:14AM -0500, Jim Buttafuoco wrote:
I couldn't get 2.4.27 to patch with the arm patches, so I downloaded 2.4.25 (with has CONFIG_FPE_NWFPE=y) and ALL tests passed. So I will file a bug report with Debian. We should also put something in the Postgresql readme about this issue.
I do not think its bug in Debian or kernel - it is expected and documented behaviour of FastFPE to have less precision. Also if you think of ARM usage scenarious it seems fine to use lighter emulation.
The question is rather how to handle it in PostgreSQL regression testing: 1) Document the need for NWFPE - which gives standard results. 2) Use FastFPE results on Linux/ARM. 3) Autodetect - ok, that was a joke.
I guess 1) is fine now. 2) should be done when FastFPE is
standard on Linux/ARM.
Why not just add an alternative regression output? pg_regress is designed to handle it, and we have quite a few of those already to deal with minor FP differences.
Reminder: here is the complete set of diffs:
*** ./expected/point.out Tue Jan 4 10:55:16 2005
--- ./results/point.out Tue Jan 4 12:40:50 2005
***************
*** 101,107 ****
| (-3,4) | 5
| (-10,0) | 10
| (-5,-12) | 13
! | (10,10) | 14.142135623731
| (5.1,34.5) | 34.8749193547455
(6 rows)--- 101,107 ----
| (-3,4) | 5
| (-10,0) | 10
| (-5,-12) | 13
! | (10,10) | 14.1421356237309
| (5.1,34.5) | 34.8749193547455
(6 rows)***************
*** 127,134 ****
| (-5,-12) | (-10,0) | 13
| (-5,-12) | (0,0) | 13
| (0,0) | (-5,-12) | 13
! | (0,0) | (10,10) | 14.142135623731
! | (10,10) | (0,0) | 14.142135623731
| (-3,4) | (10,10) | 14.3178210632764
| (10,10) | (-3,4) | 14.3178210632764
| (-5,-12) | (-3,4) | 16.1245154965971
--- 127,134 ----
| (-5,-12) | (-10,0) | 13
| (-5,-12) | (0,0) | 13
| (0,0) | (-5,-12) | 13
! | (0,0) | (10,10) | 14.1421356237309
! | (10,10) | (0,0) | 14.1421356237309
| (-3,4) | (10,10) | 14.3178210632764
| (10,10) | (-3,4) | 14.3178210632764
| (-5,-12) | (-3,4) | 16.1245154965971
***************
*** 198,204 ****
| (-10,0) | (0,0) | 10
| (-10,0) | (-5,-12) | 13
| (-5,-12) | (0,0) | 13
! | (0,0) | (10,10) | 14.142135623731
| (-3,4) | (10,10) | 14.3178210632764
| (-5,-12) | (-3,4) | 16.1245154965971
| (-10,0) | (10,10) | 22.3606797749979
--- 198,204 ----
| (-10,0) | (0,0) | 10
| (-10,0) | (-5,-12) | 13
| (-5,-12) | (0,0) | 13
! | (0,0) | (10,10) | 14.1421356237309
| (-3,4) | (10,10) | 14.3178210632764
| (-5,-12) | (-3,4) | 16.1245154965971
| (-10,0) | (10,10) | 22.3606797749979
cheers
andrew
---------------------------(end of broadcast)--------------------------- TIP 6: Have you searched our list archives?
http://archives.postgresql.org
