On Sat, 22 Jan 2005 15:31:39 +0100, Peter Eisentraut <[EMAIL PROTECTED]> wrote: > Nicolai Tufar wrote: > > 1. I renamed snprintf() to pg_snprintf(), vsnprintf() to > > pg_vsnprintf() and introduced pg_printf() that calls pg_vsnprintf(). > > This is not necessary. You will notice that we already have configure > tests of snprintf format specifiers (%lld etc.), so using the original > function names is OK even in that case.
how about a test for the thing like: printf("%2$s %1$s!\n", "world", "Hello"); It is what I am trying to solve :( > > 5. Before running regression test I always ran make install, > > apparently because libpq is read from /usr/local/. > > That's because of the -rpath. I see. Thanks for information. > > > 2. Why would we not just take FreeBSD's vfprintf() and use it > > instead? > > Try it. It's painful. src/port/snprintf.c is not not a particularly pretty. And after my rework it got even uglier. I have looked at FreeBDS's one and it is not *that* complicated. Would you like me to try to incorporate into PostgreSQL. NetBSD's one is somewhat simplier but does not support %n$ feature by the way. > > 4. What %m format string is used for? And where is it handled. Do I > > need to implement it? > > It's only used in the error reporting functions in the server and is > handled there. You don't need to worry about it. Oh, that is a relief. > Peter Eisentraut Nicolai ---------------------------(end of broadcast)--------------------------- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match