Neil Conway wrote: > Bruce Momjian wrote: > > The attached patch should remove the warnings but I am not applying it > > because a non-static/extern global variable should be fine in C code. > > What's the harm in applying it? Variables and functions not used outside > the compilation unit in which they are defined _should_ be marked > static; it's not required, but I think it's good style.
I didn't want to do it because I thought we would then have to do it in a lot of places, but I see pg_ctl.c does it, so I applied the patch, and fixed initdb.c to be 'static-clean' too. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq
