OK, now we have a problem. :-( While using native versions of libc functions rather than our pgport enhanced versions is OK for zic, the use of symlink is a problem because there is no native Win32 version.
Looking at zic.c::dolink, it calls symlink() if link() fails. I suppose we could bring in a file from pgport like we bring files in now from there for libpq. Is there a reason we can't still use pgport? --------------------------------------------------------------------------- Andrew Dunstan wrote: > Cygwin seems fixed, but now on my Windows box I get this: > > gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -fno-strict-aliasing > -I../../src/include -I./src/include/port/win32 -DEXEC_BACKEND > "-I../../src/include/port/win32" -DBUILDING_DLL -I. -DNO_PGPORT -c -o > zic.o zic.c > zic.c: In function `dolink': > zic.c:634: warning: implicit declaration of function `symlink' > gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -fno-strict-aliasing > -I../../src/include -I./src/include/port/win32 -DEXEC_BACKEND > "-I../../src/include/port/win32" -DBUILDING_DLL -I. -DNO_PGPORT -c -o > ialloc.o ialloc.c > gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -fno-strict-aliasing > -I../../src/include -I./src/include/port/win32 -DEXEC_BACKEND > "-I../../src/include/port/win32" -DBUILDING_DLL -I. -DNO_PGPORT -c -o > scheck.o scheck.c > ln -s localtime.c localtime-zic.c > gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -fno-strict-aliasing > -I../../src/include -I./src/include/port/win32 -DEXEC_BACKEND > "-I../../src/include/port/win32" -DBUILDING_DLL -I. -DNO_PGPORT -c -o > localtime-zic.o localtime-zic.c > gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -fno-strict-aliasing > zic.o ialloc.o scheck.o localtime-zic.o -o zic.exe > zic.o(.text+0xe99):zic.c: undefined reference to `symlink' > > cheers > > andrew > > Bruce Momjian wrote: > > >Andrew Dunstan wrote: > > > > > >>The latest timezone lib changes seem to have broken Windows and Cygwin > >>builds comprehensively. I assume that this checkin caused the problem: > >> > >>http://archives.postgresql.org/pgsql-committers/2005-07/msg00155.php : > >> > >>Restructure zic #define fprintf checks to use a NO_PGPORT macro instead. > >> > >> > > > >Actually, that patch was to fix my unix build. The big change was that > >zic no longer uses pgport routines, and that was done by someone else so > >zic would be run on the target matchine for cross-platform builds. > > > >I have applied the attached patch which should fix the problems you saw. > >It basically extends NO_PGPORT, which I expected might be required when > >I added it. > > > > > > > > > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
