On Sun, Jul 10, 2005 at 09:10:29PM +0300, Marko Kreen wrote: > On Sun, Jul 10, 2005 at 11:37:22AM -0400, Bruce Momjian wrote: > > Marko Kreen wrote: > > > I see from buildfarm, that pgcrypto fails to build on a > > > non-OpenSSL machine. The reason for it is a stale openssl/bn.h > > > include in pgp-pubdec.c. I did not spot it, as even for > > > --without-openssl build I still had OpenSSL intalled. > > > > Removed from CVS. > > One more failure: > > http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=cicada&dt=2005-07-10%2017:39:18 > > I think this is because we don't have -lz in SHLIB_LINK. > Following patch fixes it.
Here's the patch. -- marko
Index: contrib/pgcrypto/Makefile =================================================================== RCS file: /opt/arc/cvs2/pgsql/contrib/pgcrypto/Makefile,v retrieving revision 1.20 diff -u -c -r1.20 Makefile *** contrib/pgcrypto/Makefile 10 Jul 2005 03:57:55 -0000 1.20 --- contrib/pgcrypto/Makefile 10 Jul 2005 17:56:53 -0000 *************** *** 56,64 **** # Add libraries that pgcrypto depends (or might depend) on into the # shared library link. (The order in which you list them here doesn't # matter.) ! SHLIB_LINK += $(filter -lcrypt -ldes -lcrypto -lssl, $(LIBS)) ifeq ($(PORTNAME), win32) ! SHLIB_LINK += $(filter -leay32 -lssleay32, $(LIBS)) endif # to make ws2_32.lib the last library (must occur after definition of PORTNAME) --- 56,64 ---- # Add libraries that pgcrypto depends (or might depend) on into the # shared library link. (The order in which you list them here doesn't # matter.) ! SHLIB_LINK += $(filter -lcrypt -ldes -lcrypto -lssl -lz, $(LIBS)) ifeq ($(PORTNAME), win32) ! SHLIB_LINK += $(filter -leay32 -lssleay32 -lz, $(LIBS)) endif # to make ws2_32.lib the last library (must occur after definition of PORTNAME)
---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings
