FYI, I am looking into all the reports of pgindent failures and will have those fixed and a sample re-run diff posted in a few days.
--------------------------------------------------------------------------- Chuck McDevitt wrote: > Pgindent adds spaces after the stars if it doesn't recognize the thing > before the star as a typedef... Could it be that somehow the list of > typedefs included in pgindent got corrupted? > > > -----Original Message----- > > From: [EMAIL PROTECTED] [mailto:pgsql-hackers- > > [EMAIL PROTECTED] On Behalf Of Tom Lane > > Sent: Monday, November 07, 2005 8:19 AM > > To: Neil Conway > > Cc: Bruce Momjian; Hackers > > Subject: Re: [HACKERS] Another pgindent gripe > > > > Neil Conway <[EMAIL PROTECTED]> writes: > > > On a related note, most of these changes are completely bogus: > > > > > > > > http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_e > xe > > c.c.diff?r1=1.152;r2=1.153 > > > > Oy vey! Why did it insert spaces after the stars in all those > function > > declarations? That's certainly not in conformance with project style > > ... and I don't see it having happened elsewhere. > > > > Seems like pgindent has suffered some significant regressions since > the > > 8.0 run. I thought it had not been changed much at all, but evidently > > that's wrong. > > > > regards, tom lane > > > > ---------------------------(end of > broadcast)--------------------------- > > TIP 5: don't forget to increase your free space map settings > > > > ---------------------------(end of broadcast)--------------------------- > TIP 5: don't forget to increase your free space map settings > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 6: explain analyze is your friend