Alvaro Herrera wrote: > Zdenek Kotala wrote: > > Heikki Linnakangas wrote: > > >Zdenek Kotala wrote: > > >>Heikki Linnakangas wrote: > > >> > > >>>- heap page diagnostic functions > > >> > > >>I would like to take this review (after PGCon). > > > > > >Too late, Bruce applied it already :). > > > > Yes ... Never mind > > You know, the fact that it was applied does not mean that it doesn't > need review. If there is a bug on it which your review can find, we > would like to know before it is released. > > The review process is not just so that it can be flown past some evil > committee.
I forgot to add that it seems that a general feeling here is that as soon as code is committed, it is Tom Lane's problem if there is a bug, because he will track it down and fix it. So if it was committed, we can forget about it because he'll take care. -- Alvaro Herrera http://www.PlanetPostgreSQL.org/ "Granting software the freedom to evolve guarantees only different results, not better ones." (Zygo Blaxell) ---------------------------(end of broadcast)--------------------------- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
