Peter Eisentraut wrote:
Just to get an opinion, which is better:

could not open transaction log file "%s": %m
could not open control file "%s": %m
could not open data file "%s": %m
could not open temporary file "%s": %m
could not open whatever file "%s": %m

or just:

could not open file "%s": %m

It seems to me that by the time you get to a file error message of this level, the higher-level purpose of the file is pretty irrelevant. (Specific exceptions might exist.) Log analysis tools might also prefer a uniform format.

Anyway, some consistency either way would be nice.

Since we use a relative path to $PGDATA I think that:

could not open file "%s" : %m

is plenty.

Sincerely,

Joshua D. Drake





--

      === The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240
Providing the most comprehensive  PostgreSQL solutions since 1997
             http://www.commandprompt.com/

Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate
PostgreSQL Replication: http://www.commandprompt.com/products/


---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
      choose an index scan if your joining column's datatypes do not
      match

Reply via email to