Was there any consensus on this change? It or something like it is necessary to get gcov to work for contrib modules. I think adding all of $(CFLAGS) is the correct thing to do on linux because if we're going to use $(CC) to link then you don't know which of $(CFLAGS) might be necessary at link time as well. I think -pg will suffer from the same problems for example.
Index: Makefile.linux =================================================================== RCS file: /home/stark/src/REPOSITORY/pgsql/src/makefiles/Makefile.linux,v retrieving revision 1.22 diff -u -r1.22 Makefile.linux --- Makefile.linux 9 Dec 2005 21:19:36 -0000 1.22 +++ Makefile.linux 17 Jul 2007 05:52:43 -0000 @@ -11,6 +11,6 @@ endif %.so: %.o - $(CC) -shared -o $@ $< + $(CC) $(CFLAGS) -shared -o $@ $< sqlmansect = 7 -- Gregory Stark EnterpriseDB http://www.enterprisedb.com ---------------------------(end of broadcast)--------------------------- TIP 4: Have you searched our list archives? http://archives.postgresql.org
