On Tue, 2007-08-14 at 12:29 -0400, Tom Lane wrote: > "Simon Riggs" <[EMAIL PROTECTED]> writes: > > On Tue, 2007-08-14 at 12:09 -0400, Tom Lane wrote: > >> heapam.c lines 1843-1852 presume previous xmax can be hinted > >> immediately, ditto lines 2167-2176, ditto lines 2716-2725. > >> I think probably we should just remove those lines --- they are only > >> trying to save work for future tqual.c calls. > > > I'll check those out later tonight. > > [ looks closer ] Actually, we can't just dike out those code sections, > because the immediately following code assumes that XMAX_INVALID is > correct. So I guess we need to export HeapTupleSetHintBits from tqual.c > and do the full pushup in these places.
Looks good: the code is neater and better commented than before as well as being fully accurate with async commit. -- Simon Riggs EnterpriseDB http://www.enterprisedb.com ---------------------------(end of broadcast)--------------------------- TIP 4: Have you searched our list archives? http://archives.postgresql.org
