Attached is a patch for HEAD to implement Peter's suggestion to set the
SHLIB_LINK in the contrib modules that need it.

Also, this changes Makefile.aix to use SHLIB_LINK instead of LIBS so
that the changes to the contrib Makefiles are picked up correctly.
Further this makes it match more closely the link rules from
Makefile.shlib.

        -rocco

> -----Original Message-----
> From: Peter Eisentraut [mailto:[EMAIL PROTECTED] 
> Sent: Wednesday, July 20, 2005 2:12 PM
> To: Rocco Altier
> Cc: pgsql-patches@postgresql.org; Tom Lane; Andrew Dunstan; 
> Zeugswetter Andreas DAZ SD
> Subject: Re: [PATCHES] Changes for AIX buildfarm
> 
> 
> Tom Lane wrote:
> > Fair enough.  But I'm concerned about the proposed patch because it
> > seems to revert a deliberate change made some time ago:
> >
> > 
> http://developer.postgresql.org/cvsweb.cgi/pgs>
ql/src/Makefile.shlib#r
> >ev1.65
> > http://archives.postgresql.org/pgsql-committers/2002-10/msg00054.php
> >
> > so I think we need more eyeballs on the problem before deciding this
> > is a good fix.
> 
> A potentially more correct solution would be to set SHLIB_LINK in the 
> makefiles of the affected modules only.  Certainly we don't want to 
> link with all libraries all the time.
> 
> -- 
> Peter Eisentraut
> http://developer.postgresql.org/~petere/
> 

Attachment: aix.contrib.patch
Description: aix.contrib.patch

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
       subscribe-nomail command to [EMAIL PROTECTED] so that your
       message can get through to the mailing list cleanly

Reply via email to