On Fri, 2005-23-09 at 00:14 -0700, David Fetter wrote: > Yes. Please find enclosed round 2 of the patch. It implements > multiple -n's and multiple -t's, although I think it's broken for > multiple -n's with no -t's.
BTW, have you read the (extensive) prior discussion of this topic? For example, http://archives.postgresql.org/pgsql-patches/2004-07/msg00229.php There have been *at least* two previous implementations of the patch posted, so it might be worth taking a look at those other versions as well. > Also included are a few wrapper functions for doing the right thing > should any of calloc(), malloc(), realloc() and strdup() fail. Can you post this as a separate patch, please? It is unrelated, and the bulk of these changes make it difficult to review the "-t" option work. *** src/bin/pg_dump/pg_dump.h 5 Sep 2005 23:50:49 -0000 1.121 --- src/bin/pg_dump/pg_dump.h 23 Sep 2005 07:13:02 -0000 *************** *** 387,390 **** --- 387,395 ---- extern CastInfo *getCasts(int *numCasts); extern void getTableAttrs(TableInfo *tbinfo, int numTables); + void *pg_calloc(size_t nmemb, size_t size); + void *pg_malloc(size_t size); + void *pg_realloc(void *ptr, size_t size); + char *pg_strdup(const char *s); By convention, global function declarations use the "extern" keyword, so you want: extern void *pg_malloc(size_t sz); etc. -Neil ---------------------------(end of broadcast)--------------------------- TIP 4: Have you searched our list archives? http://archives.postgresql.org
