Tom Lane wrote: > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > OK, snprintf.c fixed. I added a 'stream' and outlen parameter to all > > the calls, and cleaned up the switch() statement that was outputing > > twice. When we were outputing just to a string, it didn't matter, but > > now that we are also outputting to a stream, it does. > > I found a whole bunch more problems than this :-(. I've committed a > cleaned-up version that seems to work correctly in a simple standalone > testbed, but it'd be a good idea to exercise it inside PG as well. > Can you try regression tests and the factorial() problem on CVS tip?
Thanks. Tested 8.1.1 and CVS tip and all compile, and regression pass. I also tested the factorial test and the result looks perfect, thanks! > The problems are sufficiently bad that it might be a good idea to > backport the fixes into 8.0 and before as well --- but I note that > the ABI is different (pg_snprintf vs snprintf, etc) so this requires > a bit of investigation rather than just committing the file as-is. Not as many 8.0.X platforms used *printf because we didn't test %$ for its use on that release, so my bet is that very few platforms would be using it. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 1: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly