Tom Lane wrote: > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > Tom Lane wrote: > >> What about the question of whether $(DESTDIR) belongs there or not? > >> I think we had concluded that PGXS shouldn't ever use $(DESTDIR), > >> because that's only for install-time stuff. > > > I considered that a separate issue and didn't explore it, but I think > > you are right that $(DESTDIR) makes no sense so I will remove it. > > > Patch attached. > > If these are bogus then so are the uses in Makefile.aix and > Makefile.darwin.
Done, and backpatched. > I'm a bit bothered by the ones in pgxs.mk, too, although I suspect we > have to leave those there for the benefit of contrib? No idea, sorry. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
Index: src/makefiles/Makefile.aix =================================================================== RCS file: /cvsroot/pgsql/src/makefiles/Makefile.aix,v retrieving revision 1.23 diff -c -c -r1.23 Makefile.aix *** src/makefiles/Makefile.aix 28 Oct 2005 17:32:22 -0000 1.23 --- src/makefiles/Makefile.aix 19 Jan 2006 21:16:36 -0000 *************** *** 22,28 **** POSTGRES_IMP= postgres$(IMPSUFF) ifdef PGXS ! BE_DLLLIBS= -Wl,-bI:$(DESTDIR)$(bindir)/postgres/$(POSTGRES_IMP) else BE_DLLLIBS= -Wl,-bI:$(top_builddir)/src/backend/$(POSTGRES_IMP) endif --- 22,28 ---- POSTGRES_IMP= postgres$(IMPSUFF) ifdef PGXS ! BE_DLLLIBS= -Wl,-bI:$(bindir)/postgres/$(POSTGRES_IMP) else BE_DLLLIBS= -Wl,-bI:$(top_builddir)/src/backend/$(POSTGRES_IMP) endif Index: src/makefiles/Makefile.darwin =================================================================== RCS file: /cvsroot/pgsql/src/makefiles/Makefile.darwin,v retrieving revision 1.8 diff -c -c -r1.8 Makefile.darwin *** src/makefiles/Makefile.darwin 17 Dec 2004 03:52:48 -0000 1.8 --- src/makefiles/Makefile.darwin 19 Jan 2006 21:16:36 -0000 *************** *** 5,11 **** CFLAGS_SL = ifdef PGXS ! BE_DLLLIBS= -bundle_loader $(DESTDIR)$(bindir)/postgres else BE_DLLLIBS= -bundle_loader $(top_builddir)/src/backend/postgres endif --- 5,11 ---- CFLAGS_SL = ifdef PGXS ! BE_DLLLIBS= -bundle_loader $(bindir)/postgres else BE_DLLLIBS= -bundle_loader $(top_builddir)/src/backend/postgres endif
---------------------------(end of broadcast)--------------------------- TIP 5: don't forget to increase your free space map settings
