Zdenek Kotala <[EMAIL PROTECTED]> writes: > I created new regression test for check SET and RESET commands and > configuration subsystem.
Does this actually accomplish anything? The checks that retail SETs and RESETs work seem redundant with numerous existing tests. The SELECT from pg_settings is a seriously bad idea: it adds 100K of bloat to the regression files, tests nothing of great interest, and will cause regression test failures under a large variety of scenarios (eg, initdb chose less-than-max shared memory settings, or we're doing "make installcheck" against an installed server with even one nondefault parameter setting). Not to mention the extra maintenance effort of updating this expected file anytime anyone changes guc.c at all, even to the extent of fixing grammar in a GUC-variable description. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 2: Don't 'kill -9' the postmaster